[
https://issues.apache.org/jira/browse/SAMZA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991530#comment-15991530
]
ASF GitHub Bot commented on SAMZA-1251:
---------------------------------------
GitHub user navina opened a pull request:
https://github.com/apache/samza/pull/153
SAMZA-1251 - Remove DebounceTimer dependency from ZkLeaderElector
Fyi: This PR depends on PR #148
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/navina/samza SAMZA-1251
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #153
----
commit d81cfdca4b84f02b86ab70657c8c4636e8902b9a
Author: Navina Ramesh <[email protected]>
Date: 2017-04-14T00:20:38Z
Remove containerId from SamzaContainer.apply
commit c4a10242b6e85345ed4515b98ec407435c1fdce1
Author: Navina Ramesh <[email protected]>
Date: 2017-04-14T00:22:01Z
Removing onBecomingLeader for readability
commit 56028361552b37a27991c6cac1f3e00cc3d3a0f2
Author: Navina Ramesh <[email protected]>
Date: 2017-04-14T00:26:01Z
Removing awaitStart
commit fd99fd65fb437afed04240b3971b3cefc1f52f1d
Author: Navina Ramesh <[email protected]>
Date: 2017-04-14T19:12:46Z
Added JobCoordinator Listener. Trying to remove Samzacontainer controller
commit e77aa502df74cedb87c50a8e039135975504381e
Author: Navina Ramesh <[email protected]>
Date: 2017-04-25T01:36:14Z
Adding ProcessorErrorHandler, SamzaContainerStatus, JobCoordinatorListener,
SamzaContainerListener
commit 3cbf259c1e9fea7a4d24af93a812e75d9947aac8
Author: Navina Ramesh <[email protected]>
Date: 2017-04-26T23:01:24Z
Documenting state transitions for SamzaContainer
commit 679b2f54aa7a39c8dae688f9b446aa9bad9d267f
Author: Navina Ramesh <[email protected]>
Date: 2017-04-26T23:03:00Z
adding some log lines in LocalContainerRunner
commit 3b65cc983d7d734d6fdf2a81cb155fbad0e774b3
Author: Navina Ramesh <[email protected]>
Date: 2017-04-27T01:36:25Z
Fixed integration test failures by throwing the exception in the listener
for ThreadJob
commit b1b61f58b2e06a1e7f5fc602fe9007d4c1a003a0
Author: Navina Ramesh <[email protected]>
Date: 2017-04-27T19:42:54Z
Added a few tests in TestSamzaContainer
commit a2db96924ebd479e2110fc611c86c3c310336212
Author: Navina Ramesh <[email protected]>
Date: 2017-04-27T23:38:29Z
Added test for sp.stop()
commit bc74cd5670aacfe5c4eae7968973e68f9f700876
Author: Navina Ramesh <[email protected]>
Date: 2017-04-28T00:23:32Z
Adding setContainerListener explicitly in SamzaContainer
commit 07adf3c6ce39a893a0995498bc012cf6c14c43be
Author: Navina Ramesh <[email protected]>
Date: 2017-04-28T02:38:24Z
Added documentation in JobCoordinator interface
commit 78a73540cc0cd84db286737b190c596dcde93d1f
Author: Navina Ramesh <[email protected]>
Date: 2017-04-28T02:43:00Z
Removed ProcessorErrorHandler
commit 5d1b28c6b566ca691a955d94bb1daf29a96737ef
Author: Navina Ramesh <[email protected]>
Date: 2017-04-28T02:45:47Z
Removing commetned out code
commit 42ffc7d6c1d5e657b35d9482df30f0e201bdbb27
Author: Navina Ramesh <[email protected]>
Date: 2017-04-28T05:00:40Z
Adding docs to JobCoordinatorListener
commit 5ff163cf19c85875a0e2a8d85682487186ffc6c5
Author: Navina Ramesh <[email protected]>
Date: 2017-04-28T05:36:02Z
Added javadocs for SamzaContainerListener
commit f3551656037a058aebd62e9f7dacaafeb49d2f94
Author: Navina Ramesh <[email protected]>
Date: 2017-04-28T06:33:49Z
Cleaning up StreamProcessor code and jobCoordinator docs
commit c624d75afd77dd028a4406d6e07d2ef801098b03
Author: Navina Ramesh <[email protected]>
Date: 2017-04-28T07:09:36Z
Fixing standaloneJobCoordinator
commit c116a3c55149a4cca738a66ec925569385568be9
Author: Navina Ramesh <[email protected]>
Date: 2017-04-28T07:14:04Z
Adding null checks on processorListener
commit 6f0715c4944255409bd78fd178c8e9976e60f485
Author: Navina Ramesh <[email protected]>
Date: 2017-04-28T07:32:37Z
Fixing ZkJobCoordinator
commit 73e993d65d8d3a5ce26af581055ac829981b9b7c
Author: Navina Ramesh <[email protected]>
Date: 2017-04-29T01:24:52Z
LeaderElector should explicitly register a listener. Cleaning up the
ZkLeaderElector implementation
commit 25d0eddfbae2aacbe03751074bcdb035cdf6bd18
Author: Navina Ramesh <[email protected]>
Date: 2017-05-01T18:47:52Z
Moving LeaderElectorListener out of ZkController and refactoring
ZkJobCoordinator to use LeaderElector as a library w/o ZkControlelr in the
middle
commit 1a9533da71c92804aef5a4268afe08b92cc6572d
Author: Navina Ramesh <[email protected]>
Date: 2017-05-01T18:53:25Z
Adding some javadocs to ZkController and ZkControllerListener interface
commit c599fd1cef65ecbfe9c60815ace1411558cb4174
Author: Navina Ramesh <[email protected]>
Date: 2017-05-01T20:16:18Z
[Bug-fix] OnBecomeLeader and OnProcessorChange should be queued up under
the same name
----
> Remove DebounceTimer dependency from ZkLeaderElector
> ----------------------------------------------------
>
> Key: SAMZA-1251
> URL: https://issues.apache.org/jira/browse/SAMZA-1251
> Project: Samza
> Issue Type: Sub-task
> Reporter: Navina Ramesh
> Assignee: Navina Ramesh
> Fix For: 0.13.0
>
>
> The debounce timer is currently being passed around in every class with no
> specific criteria. This complicates testing and makes it hard to
> compartmentalize responsibilities of different components such as
> ZkJobCoordinator, ZkController etc. It tightly couples the
> ScheduleAfterDebounceTime with ZkLeader and CoordinationUtils.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
