Repository: samza
Updated Branches:
  refs/heads/master fb7aa73f5 -> d8534b5d8


SAMZA-1266: Unable to use MetricsSnapshotReporterFactory with fluent API

Author: Jacob Maes <[email protected]>

Reviewers: Prateek Maheshwari <[email protected]>, Navina Ramesh 
<[email protected]>

Closes #167 from jmakes/samza-1266


Project: http://git-wip-us.apache.org/repos/asf/samza/repo
Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/d8534b5d
Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/d8534b5d
Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/d8534b5d

Branch: refs/heads/master
Commit: d8534b5d860dcd89a8163f2faf5efa9836498dc6
Parents: fb7aa73
Author: Jacob Maes <[email protected]>
Authored: Fri May 5 15:48:32 2017 -0700
Committer: Jacob Maes <[email protected]>
Committed: Fri May 5 15:48:32 2017 -0700

----------------------------------------------------------------------
 .../samza/metrics/reporter/MetricsSnapshotReporterFactory.scala | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/samza/blob/d8534b5d/samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporterFactory.scala
----------------------------------------------------------------------
diff --git 
a/samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporterFactory.scala
 
b/samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporterFactory.scala
index 60a8d84..052a9d3 100644
--- 
a/samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporterFactory.scala
+++ 
b/samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporterFactory.scala
@@ -21,7 +21,7 @@ package org.apache.samza.metrics.reporter
 
 import org.apache.samza.util.Logging
 import org.apache.samza.SamzaException
-import org.apache.samza.config.Config
+import org.apache.samza.config.{ApplicationConfig, Config}
 import org.apache.samza.config.JobConfig.Config2Job
 import org.apache.samza.config.MetricsConfig.Config2Metrics
 import org.apache.samza.config.SystemConfig.Config2System
@@ -49,7 +49,8 @@ class MetricsSnapshotReporterFactory extends 
MetricsReporterFactory with Logging
 
     val taskClass = config
       .getTaskClass
-      .getOrElse(throw new SamzaException("No task class defined for config."))
+      .orElse(Option(new ApplicationConfig(config).getAppClass()))
+      .getOrElse(throw new SamzaException("No task or app class defined for 
config."))
 
     val version = 
Option(Class.forName(taskClass).getPackage.getImplementationVersion)
       .getOrElse({

Reply via email to