[
https://issues.apache.org/jira/browse/SAMZA-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065277#comment-16065277
]
ASF GitHub Bot commented on SAMZA-1347:
---------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/samza/pull/233
> GroupByContainerIds NPE if containerIds list is null
> ----------------------------------------------------
>
> Key: SAMZA-1347
> URL: https://issues.apache.org/jira/browse/SAMZA-1347
> Project: Samza
> Issue Type: Improvement
> Reporter: Jake Maes
> Assignee: Jake Maes
>
> Another low-hanging fruit. The null check in group() happens AFTER checking
> the size of containerIds. These statements should be reordered.
> Also, Since the group(tasks) method always calls the group(tasks,
> containerIds) method, lets just move all the safety checks there.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
