[
https://issues.apache.org/jira/browse/SAMZA-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129476#comment-16129476
]
ASF GitHub Bot commented on SAMZA-1396:
---------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/samza/pull/274
> TestZkLocalApplication tests fails after SAMZA-1385
> ---------------------------------------------------
>
> Key: SAMZA-1396
> URL: https://issues.apache.org/jira/browse/SAMZA-1396
> Project: Samza
> Issue Type: Bug
> Reporter: Navina Ramesh
> Assignee: Navina Ramesh
> Priority: Blocker
> Fix For: 0.13.1
>
>
> SAMZA-1385 fixed the ZkPath collision in Zk between LocalApplicationRunner
> and ZkJobCoordinator factory.
> 1. The context within the zk tree is determined by the used as root when
> creating zkClient. However, we are using a different mechanism to build
> `ZkKeyBuilder` in this integration test. Hence, the assertions were failing.
> 2. With the intention to support multi-stage applications where each
> application will have one or more jobs, we introduced app.name and app.id
> configuration. As of today, we only support single stage jobs, which means
> that application and job are synonymous. Hence, job.name and job.id in the
> configuration should be the same as app.name and app.id. This has to be fixed
> in the integration test.
> In the future, it will be great if the component generating the graph and
> configs for each stage can also inject the job name and id into the config.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
