[
https://issues.apache.org/jira/browse/SAMZA-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130831#comment-16130831
]
ASF GitHub Bot commented on SAMZA-1386:
---------------------------------------
GitHub user xinyuiscool opened a pull request:
https://github.com/apache/samza/pull/277
SAMZA-1386: Inline End-of-stream and Watermark logic inside OperatorImpl
This patch contains the following changes:
1. Refactor watermark and end-of-stream logic. The aggregation/handling has
been moved from WatermarkManager/EndOfStreamManager to be inline inside
OperatorImpl. This is for keeping the logic in one place.
2. Now subclass of OperatorImpl will override handleWatermark() to do its
specific handling, such as fire trigger.
3. Add emitWatermark() in OperatorImpl so subclass can call it to emit
watermark upon receiving a message or watermark.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xinyuiscool/samza SAMZA-1386
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/277.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #277
----
commit 580dc892b54e772472c5668624a753a757e54fd2
Author: Xinyu Liu <[email protected]>
Date: 2017-08-10T01:25:01Z
Refactor end-of-stream
commit 368db3560d7f443c517b66ffb6bcf596cf5bcf07
Author: Xinyu Liu <[email protected]>
Date: 2017-08-15T00:33:19Z
Refactor end-of-stream
commit f983dba929bb2bc855f07c904735d6e0089d6eb2
Author: Xinyu Liu <[email protected]>
Date: 2017-08-16T00:26:18Z
Refactor watermark
commit fab42f82d04c6cb7bdaf4f7ed1c1dd36f7ce4134
Author: Xinyu Liu <[email protected]>
Date: 2017-08-16T21:40:13Z
Add unit tests for watermarks
----
> Inline End-of-stream and Watermark logic inside OperatorImpl
> ------------------------------------------------------------
>
> Key: SAMZA-1386
> URL: https://issues.apache.org/jira/browse/SAMZA-1386
> Project: Samza
> Issue Type: Bug
> Affects Versions: 0.14.0
> Reporter: Xinyu Liu
> Assignee: Xinyu Liu
>
> Currently both EOS and Watermark aggregation/population logic is inside
> TaskInstance. Since watermark handling logic is in OperatorImpl, it makes
> sense to consolidate them together inside OperatorImpl, and make it feasible
> to provide user API to emit watermarks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
