[
https://issues.apache.org/jira/browse/SAMZA-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299030#comment-16299030
]
ASF GitHub Bot commented on SAMZA-1539:
---------------------------------------
GitHub user jmakes opened a pull request:
https://github.com/apache/samza/pull/390
SAMZA-1539: KafkaProducer potential hang on close() when task.drop.pr…
…oducer.errors==true
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmakes/samza samza-1539
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/390.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #390
----
commit 87a39fc076dde94574590dff6ae7fd070f012a64
Author: Jacob Maes <jmakes@...>
Date: 2017-12-20T20:21:59Z
SAMZA-1539: KafkaProducer potential hang on close() when
task.drop.producer.errors==true
----
> KafkaProducer potential hang on close() when task.drop.producer.errors==true
> ----------------------------------------------------------------------------
>
> Key: SAMZA-1539
> URL: https://issues.apache.org/jira/browse/SAMZA-1539
> Project: Samza
> Issue Type: Bug
> Reporter: Jake Maes
> Assignee: Jake Maes
>
> The issue is caused by 2 bad behaviors:
> 1. KafkaProducer.close() does an unbounded thread.join() even when a force
> close (timeout == 0 ms) is specified.
> 2. KafkaSystemProducer.handleSendException() has a synchronized block to
> recreate the producer when task.drop.producer.errors==true. When the IO
> thread is waiting on the synchronized block, it prevents the KafkaProducer
> from joining the IO thread.
> Fixing either one will fix the issue, but we will close this ticket as soon
> as the Samza side is tested and committed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
