Repository: samza Updated Branches: refs/heads/master ef1c9625c -> 9a8099cda
Fix a couple sonarcloud issues with samza-1537 Author: Jacob Maes <[email protected]> Reviewers: Jagadish <[email protected]> Closes #393 from jmakes/streamappender-sonarcloud Project: http://git-wip-us.apache.org/repos/asf/samza/repo Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/9a8099cd Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/9a8099cd Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/9a8099cd Branch: refs/heads/master Commit: 9a8099cdaa2a8ee6fa64d263ebf6704ee5a108da Parents: ef1c962 Author: Jacob Maes <[email protected]> Authored: Fri Dec 22 11:41:27 2017 -0800 Committer: Jacob Maes <--global> Committed: Fri Dec 22 11:41:27 2017 -0800 ---------------------------------------------------------------------- .../java/org/apache/samza/logging/log4j/StreamAppender.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/samza/blob/9a8099cd/samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java ---------------------------------------------------------------------- diff --git a/samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java b/samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java index 0ea8b68..5f41959 100644 --- a/samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java +++ b/samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java @@ -152,7 +152,7 @@ public class StreamAppender extends AppenderSkeleton { // Emit a metric which can be monitored to ensure it doesn't happen often. metrics.logMessagesDropped.inc(messagesDropped); } - metrics.bufferFillPct.set(Math.round(100 * logQueue.size() / DEFAULT_QUEUE_SIZE)); + metrics.bufferFillPct.set(Math.round(100f * logQueue.size() / DEFAULT_QUEUE_SIZE)); } } catch (Exception e) { System.err.println("[StreamAppender] Error sending log message:"); @@ -188,7 +188,8 @@ public class StreamAppender extends AppenderSkeleton { try { transferThread.join(); } catch (InterruptedException e) { - log.error("Interrupted while waiting for sink thread to finish.", e); + log.error("Interrupted while waiting for transfer thread to finish.", e); + Thread.currentThread().interrupt(); } flushSystemProducer();
