Repository: samza Updated Branches: refs/heads/master 9893069cb -> 267dfc6ba
Fix for the TestSamzaSqlApplicationConfig.testConfigInit Currently testConfigInit checks for a hardcoded number for udfs. Whenever a new UDF is added, This test is going to fail if it is not updated. Changed the test to validate the number of udfs based on the config that is passed. Author: Srinivasulu Punuru <[email protected]> Reviewers: Prateek Maheshwari <[email protected]> Closes #403 from srinipunuru/testfix.1 Project: http://git-wip-us.apache.org/repos/asf/samza/repo Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/267dfc6b Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/267dfc6b Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/267dfc6b Branch: refs/heads/master Commit: 267dfc6ba0eddd78d5913663496c65eaa1aa3c0b Parents: 9893069 Author: Srinivasulu Punuru <[email protected]> Authored: Wed Jan 10 17:14:03 2018 -0800 Committer: Prateek Maheshwari <[email protected]> Committed: Wed Jan 10 17:14:03 2018 -0800 ---------------------------------------------------------------------- .../org/apache/samza/sql/TestSamzaSqlApplicationConfig.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/samza/blob/267dfc6b/samza-sql/src/test/java/org/apache/samza/sql/TestSamzaSqlApplicationConfig.java ---------------------------------------------------------------------- diff --git a/samza-sql/src/test/java/org/apache/samza/sql/TestSamzaSqlApplicationConfig.java b/samza-sql/src/test/java/org/apache/samza/sql/TestSamzaSqlApplicationConfig.java index 0b85339..1c5fc41 100644 --- a/samza-sql/src/test/java/org/apache/samza/sql/TestSamzaSqlApplicationConfig.java +++ b/samza-sql/src/test/java/org/apache/samza/sql/TestSamzaSqlApplicationConfig.java @@ -24,6 +24,7 @@ import java.util.Map; import junit.framework.Assert; import org.apache.samza.SamzaException; import org.apache.samza.config.MapConfig; +import org.apache.samza.sql.impl.ConfigBasedUdfResolver; import org.apache.samza.sql.interfaces.SqlSystemStreamConfig; import org.apache.samza.sql.runner.SamzaSqlApplicationConfig; import org.apache.samza.sql.testutil.SamzaSqlTestConfig; @@ -36,9 +37,11 @@ public class TestSamzaSqlApplicationConfig { public void testConfigInit() { Map<String, String> config = SamzaSqlTestConfig.fetchStaticConfigsWithFactories(10); config.put(SamzaSqlApplicationConfig.CFG_SQL_STMT, "Insert into testavro.COMPLEX1 select * from testavro.SIMPLE1"); + String configUdfResolverDomain = String.format(SamzaSqlApplicationConfig.CFG_FMT_UDF_RESOLVER_DOMAIN, "config"); + int numUdfs = config.get(configUdfResolverDomain + ConfigBasedUdfResolver.CFG_UDF_CLASSES).split(",").length; SamzaSqlApplicationConfig samzaSqlApplicationConfig = new SamzaSqlApplicationConfig(new MapConfig(config)); Assert.assertEquals(1, samzaSqlApplicationConfig.getQueryInfo().size()); - Assert.assertEquals(3, samzaSqlApplicationConfig.getUdfMetadata().size()); + Assert.assertEquals(numUdfs, samzaSqlApplicationConfig.getUdfMetadata().size()); Assert.assertEquals(1, samzaSqlApplicationConfig.getInputSystemStreamConfigBySource().size()); Assert.assertEquals(1, samzaSqlApplicationConfig.getOutputSystemStreamConfigsBySource().size()); }
