[ 
https://issues.apache.org/jira/browse/SAMZA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373716#comment-16373716
 ] 

ASF GitHub Bot commented on SAMZA-1595:
---------------------------------------

GitHub user shanthoosh opened a pull request:

    https://github.com/apache/samza/pull/430

    SAMZA-1595: Fix scalacCompileOptions format to build with zinc scala 
compiler.

    Zinc scala compiler(part of gradle version >= 3.0) expects the scala 
compilation arguments as a list(where each compilation argument is an element 
of the list).
    
    In samza, the compilation arguments are concatenated into a single string 
and passed to the compiler.
    
    This causes build failures when samza is built with Zinc scala compiler.
    
    Existing ant scala compiler used to build samza in open source accepts the 
compilation arguments both as list and string.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shanthoosh/samza master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/430.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #430
    
----
commit a1ff8325a820a082c93eb552e3dcd21f45306d62
Author: Shanthoosh Venkataraman <svenkataraman@...>
Date:   2018-02-22T23:42:33Z

    Fix scalacCompileOptions format to build with zinc scala compiler.

----


> Fix scalacCompileOptions format to build with zinc scala compiler.
> ------------------------------------------------------------------
>
>                 Key: SAMZA-1595
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1595
>             Project: Samza
>          Issue Type: Improvement
>            Reporter: Shanthoosh Venkataraman
>            Assignee: Shanthoosh Venkataraman
>            Priority: Major
>
> Zinc scala compiler(part of gradle version >= 3.0) expects the scala 
> compilation arguments as a list(where each compilation argument is an element 
> of the list).
> In samza, the compilation arguments are concatenated into a single string and 
> passed to the compiler.
> This causes build failures when samza is built with gradle version > 3.0.
> Existing ant scala compiler used to build samza in open source accepts the 
> compilation arguments  as both list and string.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to