[ https://issues.apache.org/jira/browse/SAMZA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395512#comment-16395512 ]
ASF GitHub Bot commented on SAMZA-1609: --------------------------------------- GitHub user Sanil15 opened a pull request: https://github.com/apache/samza/pull/445 SAMZA-1609 Refactoring SamzaContainer to take SystemFactories as an argument - This is a pre-req to SEP-8 (https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=71013043) - A subtask to https://issues.apache.org/jira/browse/SAMZA-1395 - I have updated tests/dependencies to the best of my knowledge, please advice if some refactoring can be improved Tested with ./gradlew clean build You can merge this pull request into a Git repository by running: $ git pull https://github.com/Sanil15/samza SAMZA-1395 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/samza/pull/445.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #445 ---- commit 683c853ddc868f3375519629988df546b0432416 Author: sanil15 <sanil.jain15@...> Date: 2018-03-10T00:43:01Z Refactoring SamzaContainer to take SystemFactories as an argument ---- > Refactor SamzaContainer to take in SystemFactories > -------------------------------------------------- > > Key: SAMZA-1609 > URL: https://issues.apache.org/jira/browse/SAMZA-1609 > Project: Samza > Issue Type: Sub-task > Reporter: Bharath Kumarasubramanian > Assignee: Sanil Jain > Priority: Major > > Currently, SamzaContainer is responsible for creating SystemFactories using > class loading. We want to move this to runner since it is responsible for > creating intermediate streams and seems a natural resting place for factory > creation. > Additionally, this is a pre-requisite for in-memory system to initialize the > data source. -- This message was sent by Atlassian JIRA (v7.6.3#76005)