[ 
https://issues.apache.org/jira/browse/SAMZA-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cameron Lee updated SAMZA-1709:
-------------------------------
    Description: 
An instance of SystemAdmins is created when instantiating any 
AbstractApplicationRunner, but the SystemAdmins is only actually needed for 
some of the methods for some of the runners. For example, 
LocalApplicationRunner.kill does not need SystemAdmins, and 
LocalContainerRunner does not need SystemAdmins for anything.

Doing lazy instantiation allows us to more easily manage the SystemAdmins 
lifecycle, since it removes the need to add lifecycle hooks for the 
ApplicationRunner.

This also fixes the lifecycle management for SystemAdmins in ApplicationRunners.

  was:
An instance of SystemAdmins is created when instantiating any 
AbstractApplicationRunner, but the SystemAdmins is only actually needed for 
some of the methods for some of the runners. For example, 
LocalApplicationRunner.kill does not need SystemAdmins, and 
LocalContainerRunner does not need SystemAdmins for anything.

Doing lazy instantiation allows us to more easily manage the SystemAdmins 
lifecycle, since it removes the need to add lifecycle hooks for the 
ApplicationRunner.


> Use lazy creation for SystemAdmins in ApplicationRunners
> --------------------------------------------------------
>
>                 Key: SAMZA-1709
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1709
>             Project: Samza
>          Issue Type: Improvement
>            Reporter: Cameron Lee
>            Assignee: Cameron Lee
>            Priority: Major
>
> An instance of SystemAdmins is created when instantiating any 
> AbstractApplicationRunner, but the SystemAdmins is only actually needed for 
> some of the methods for some of the runners. For example, 
> LocalApplicationRunner.kill does not need SystemAdmins, and 
> LocalContainerRunner does not need SystemAdmins for anything.
> Doing lazy instantiation allows us to more easily manage the SystemAdmins 
> lifecycle, since it removes the need to add lifecycle hooks for the 
> ApplicationRunner.
> This also fixes the lifecycle management for SystemAdmins in 
> ApplicationRunners.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to