[
https://issues.apache.org/jira/browse/SAMZA-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470835#comment-16470835
]
ASF GitHub Bot commented on SAMZA-1700:
---------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/samza/pull/509
> Clean up SystemAdmins instance creation flows
> ---------------------------------------------
>
> Key: SAMZA-1700
> URL: https://issues.apache.org/jira/browse/SAMZA-1700
> Project: Samza
> Issue Type: Improvement
> Reporter: Cameron Lee
> Assignee: Cameron Lee
> Priority: Major
>
> The SystemAdmins class has a special "test" constructor for building
> SystemAdmins instances for unit tests. However, that test constructor has
> leaked into non-test code.
> This makes it harder to manage all flows which use SystemAdmins. An upcoming
> change is to fix lifecycle management for SystemAdmins in the
> ApplicationRunner classes, so doing some clean up will help that future
> change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
