Repository: samza Updated Branches: refs/heads/0.14.1 adb514aae -> 1e1330cef
Fixed test failure for TestRocksDbKeyValueStoreJava#testPerf Iterators (incl. those obtained from snapshots) must be closed before store close. Author: Prateek Maheshwari <[email protected]> Reviewers: Xinyu Liu <[email protected]> Closes #514 from prateekm/rocksdb-test-fi (cherry picked from commit 54c690e6fc52ac13d1c59fe1bd1c34f35f710164) Signed-off-by: xiliu <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/samza/repo Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/1e1330ce Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/1e1330ce Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/1e1330ce Branch: refs/heads/0.14.1 Commit: 1e1330cefbcfc7f2ff8e20c8ff19c465f7df4b66 Parents: adb514a Author: Prateek Maheshwari <[email protected]> Authored: Thu May 10 12:16:33 2018 -0700 Committer: xiliu <[email protected]> Committed: Thu May 10 12:16:45 2018 -0700 ---------------------------------------------------------------------- .../storage/kv/TestRocksDbKeyValueStoreJava.java | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/samza/blob/1e1330ce/samza-kv-rocksdb/src/test/java/org/apache/samza/storage/kv/TestRocksDbKeyValueStoreJava.java ---------------------------------------------------------------------- diff --git a/samza-kv-rocksdb/src/test/java/org/apache/samza/storage/kv/TestRocksDbKeyValueStoreJava.java b/samza-kv-rocksdb/src/test/java/org/apache/samza/storage/kv/TestRocksDbKeyValueStoreJava.java index a69010c..96a26ff 100644 --- a/samza-kv-rocksdb/src/test/java/org/apache/samza/storage/kv/TestRocksDbKeyValueStoreJava.java +++ b/samza-kv-rocksdb/src/test/java/org/apache/samza/storage/kv/TestRocksDbKeyValueStoreJava.java @@ -103,24 +103,27 @@ public class TestRocksDbKeyValueStoreJava { byte[] lastKey = genKey(outputStream, prefix, Integer.MAX_VALUE); long start; - KeyValueIterator iter; start = System.currentTimeMillis(); - iter = store.range(firstKey, lastKey); + KeyValueIterator<byte[], byte[]> iterator1 = store.range(firstKey, lastKey); long rangeTime = System.currentTimeMillis() - start; start = System.currentTimeMillis(); - Iterators.size(iter); + Iterators.size(iterator1); long rangeIterTime = System.currentTimeMillis() - start; System.out.println("range iter create time: " + rangeTime + ", iterate time: " + rangeIterTime); - + iterator1.close(); // Please comment out range query part in order to do an accurate perf test for snapshot start = System.currentTimeMillis(); - iter = store.snapshot(firstKey, lastKey).iterator(); + KeyValueSnapshot<byte[], byte[]> snapshot = store.snapshot(firstKey, lastKey); + KeyValueIterator<byte[], byte[]> iterator2 = snapshot.iterator(); long snapshotTime = System.currentTimeMillis() - start; start = System.currentTimeMillis(); - Iterators.size(iter); + Iterators.size(iterator2); long snapshotIterTime = System.currentTimeMillis() - start; System.out.println("snapshot iter create time: " + snapshotTime + ", iterate time: " + snapshotIterTime); + iterator2.close(); + snapshot.close(); + store.close(); } private byte[] genKey(ByteArrayOutputStream outputStream, String prefix, int i) throws Exception {
