[ 
https://issues.apache.org/jira/browse/SAMZA-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471174#comment-16471174
 ] 

ASF GitHub Bot commented on SAMZA-1559:
---------------------------------------

GitHub user fredji97 opened a pull request:

    https://github.com/apache/samza/pull/517

    SAMZA-1559 moving hello-samza repo to samza repo and put in samza-samples 
directory

    Tested and jobs can be deployed in the new place. 
    After this is committed, we will do the following two in order: 
    1. adjust the documentation to use the sample jobs from the new place;
    2. remove the old hello-samza repo. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fredji97/samza master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/517.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #517
    
----
commit 851f3db9b0afcb11eca72808040750ce185cf7f6
Author: Fred Ji <haifeng.ji@...>
Date:   2018-05-10T21:42:51Z

    SAMZA-1559 moving hello-samza repo to samza repo and put in samza-samples 
directory

----


> merge hello-samza to apache/samza
> ---------------------------------
>
>                 Key: SAMZA-1559
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1559
>             Project: Samza
>          Issue Type: Test
>            Reporter: Fred Ji
>            Assignee: Fred Ji
>            Priority: Major
>
> hello-samza currently is a separate repo, but samza test relies on some code 
> from hello-samza, which make the code structure in a non-robust pattern. 
> It is better to consolidate these two repos, and make hello-samza part of 
> samza sample/test job. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to