[ 
https://issues.apache.org/jira/browse/SAMZA-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479960#comment-16479960
 ] 

ASF GitHub Bot commented on SAMZA-1720:
---------------------------------------

GitHub user shanthoosh opened a pull request:

    https://github.com/apache/samza/pull/527

    SAMZA-1720: Remove javafx.util dependency from samza-sql tests.

    In samza-sql module, currently few test 
classes(`TestSamzaSqlRelMessageSerde` and `TestSamzaSqlRelRecordSerde`) are 
dependent upon `javax.util.Pair` class. `javafx.util.Pair` is not supported by 
default in all JDK builds(example; open-jdk java-8 doesn't support `javafx` 
module) and it belongs to `javafx` package which is primarily used for 
developing GUI applications. This dependency is removed and replaced with 
`Pair` class from `apache-commons`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shanthoosh/samza SAMZA-1720

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/527.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #527
    
----
commit 43aa4a15aca1d6242276b601d8ba7e598eba2bca
Author: Shanthoosh Venkataraman <santhoshvenkat1988@...>
Date:   2018-05-18T00:55:16Z

    SAMZA-1720: Remove javafx.util dependency from samza-sql tests.
    
    In samza-sql module, currently few test classes(TestSamzaSqlRelMessageSerde 
and TestSamzaSqlRelRecordSerde) are dependent upon javax.util.Pair class.
    javafx.util.Pair is not supported by default in all JDK builds(example; 
open-jdk java-8 doesn't support javafx module) and it belongs to javafx package
    which is primarily used for developing GUI applications. This dependency is 
removed and replaced with Pair class from apache-commons.

----


> Remove javafx.util dependency from samza-sql tests.
> ---------------------------------------------------
>
>                 Key: SAMZA-1720
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1720
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Shanthoosh Venkataraman
>            Priority: Major
>
> In samza-sql module, currently few test classes(TestSamzaSqlRelMessageSerde 
> and TestSamzaSqlRelRecordSerde) are dependent upon javax.util.Pair class.
> javafx.util.Pair is not supported by default in all JDK builds(example; 
> open-jdk java-8 doesn't support javafx module) and it belongs to javafx 
> package which is primarily used for developing GUI applications. 
> This dependency has to be removed and should be replaced with either internal 
> samza classes(KV, Entry) or Pair from apache-commons.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to