[
https://issues.apache.org/jira/browse/SAMZA-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520840#comment-16520840
]
ASF GitHub Bot commented on SAMZA-1756:
---------------------------------------
GitHub user cameronlee314 opened a pull request:
https://github.com/apache/samza/pull/561
SAMZA-1756: System exit calls in ApplicationRunnerMain break ProcessJob and
cause unit tests to get skipped
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cameronlee314/samza app_runner_main_exit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/561.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #561
----
commit 190b6588d10d8d9a2c3a601afbf60d9c056e6c4e
Author: Cameron Lee <calee@...>
Date: 2018-06-22T22:25:50Z
SAMZA-1756: System exit calls in ApplicationRunnerMain break ProcessJob and
cause unit tests to get skipped
----
> System exit calls in ApplicationRunnerMain break ProcessJob and cause unit
> tests to get skipped
> -----------------------------------------------------------------------------------------------
>
> Key: SAMZA-1756
> URL: https://issues.apache.org/jira/browse/SAMZA-1756
> Project: Samza
> Issue Type: Bug
> Affects Versions: 0.15
> Reporter: Cameron Lee
> Assignee: Cameron Lee
> Priority: Major
>
> A recent change from SAMZA-1724 introduced a System.exit call at the end of
> ApplicationRunnerMain. However, ProcessJob has a non-daemon thread that needs
> to stay alive in order to deploy the container and then shut down the job
> model manager after the container shuts down.
> The System.exit will either:
> # Kill the ProcessJob thread before it can start the process
> # Kill the job model manager from ProcessJobFactory, so the new container
> process (if it does get started) is unable to reach the coordinator to get
> configs
> Also, this System.exit causes the execution of unit tests to stop early
> because the main method is called in TestApplicationRunnerMain. The
> Thread.setDefaultUncaughtExceptionHandler also causes test execution to exit
> incorrectly, since that handler seems to get triggered by some other test.
> From what I can tell, the ApplicationRunnerMain changes are there to be
> defensive, but there was no explicit case that it was fixing right now. For
> now, we can revert those changes until we know how to solve these issues.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
