[
https://issues.apache.org/jira/browse/SAMZA-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524032#comment-16524032
]
ASF GitHub Bot commented on SAMZA-1760:
---------------------------------------
GitHub user cameronlee314 opened a pull request:
https://github.com/apache/samza/pull/564
SAMZA-1760: SystemAdmin is not started properly in a few places
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cameronlee314/samza system_admin_lifecycle
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/564.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #564
----
commit d82c4a0ba1124728cc581cc4f887b11ad250dd9d
Author: Cameron Lee <calee@...>
Date: 2018-06-26T02:12:12Z
SAMZA-1760: SystemAdmin is not started properly in a few places
----
> SystemAdmin is not started properly in a few places
> ---------------------------------------------------
>
> Key: SAMZA-1760
> URL: https://issues.apache.org/jira/browse/SAMZA-1760
> Project: Samza
> Issue Type: Bug
> Reporter: Cameron Lee
> Assignee: Cameron Lee
> Priority: Major
> Fix For: 0.14.1
>
>
> [https://github.com/apache/samza/pull/397] added a "start" and "stop" to the
> SystemAdmin interface. Most places got updated to manage the lifecycle.
> However, a few places were missed (or other changes were made more recently
> that did not correctly manage the lifecycle):
> # CoordinatorStreamSystemConsumer starts a SystemAdmin in its "start"
> method. However, it uses SystemAdmin.getSystemStreamMetadata in "register",
> which is called before "start". This class properly stops SystemAdmin.
> # SystemConsumerBench does not start/stop the SystemAdmin.
> # TestRunner does not start/stop the SystemAdmin.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
