[
https://issues.apache.org/jira/browse/SAMZA-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574236#comment-16574236
]
ASF GitHub Bot commented on SAMZA-1806:
---------------------------------------
GitHub user abhishekshivanna opened a pull request:
https://github.com/apache/samza/pull/604
SAMZA-1806: Allow `task.broadcast.inputs` to be set to empty string
This fix addresses the issue that getBroadcastSystemStreamPartitions
in TaskConfigJava throws an IllegalArgumentException exception when
`task.broadcast.inputs` is set to an empty string.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/abhishekshivanna/samza master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/604.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #604
----
commit 576fbee781b4bdbd6344feca68775b34f33033cc
Author: Abhishek Shivanna <abhisheks91@...>
Date: 2018-08-09T03:26:54Z
SAMZA-1806: Fix to allow `task.broadcast.inputs` to be set to empty string
This fix addresses the issue that getBroadcastSystemStreamPartitions
in TaskConfigJava throws an IllegalArgumentException exception when
`task.broadcast.inputs` is set to an empty string.
----
> Configuring task.broadcast.inputs to an empty string raises
> IllegalArgumentException
> ------------------------------------------------------------------------------------
>
> Key: SAMZA-1806
> URL: https://issues.apache.org/jira/browse/SAMZA-1806
> Project: Samza
> Issue Type: Bug
> Reporter: Abhishek Shivanna
> Priority: Minor
>
> It looks like setting *task.broadcast.inputs* to an empty string logs the
> following exception:
> {noformat}
> Exception in thread "main" java.lang.IllegalArgumentException: incorrect
> format in . Broadcast stream names should be in the form
> 'system.stream#partitionId' or 'system.stream#[partitionN-partitionM]'
> {noformat}
> The problem stems from the fact that when *task.broadcast.inputs* is set to
> *"",* the call to the getList function in
> TaskConfigJava:getBroadcastSystemStreamPartitions() returns a List<String>
> one element (an empty string) and causes the exception to be raised.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
