[
https://issues.apache.org/jira/browse/SAMZA-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619472#comment-16619472
]
ASF GitHub Bot commented on SAMZA-1874:
---------------------------------------
GitHub user cameronlee314 opened a pull request:
https://github.com/apache/samza/pull/646
SAMZA-1874: Refactor SamzaContainer and TaskInstance unit tests to make
shared context changes easier
This replaces https://github.com/apache/samza/pull/638, I accidentally
messed up that branch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cameronlee314/samza
refactor_unit_tests_for_shared_context_new
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/646.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #646
----
commit 10e6bf47ebf6913e685048e5bdd00d1f24696a20
Author: Cameron Lee <calee@...>
Date: 2018-09-13T01:01:50Z
SAMZA-1874: Refactor SamzaContainer and TaskInstance unit tests to make
shared context changes easier
commit 5d552996ac50d2a0b1dd5034a624d9417e74dc57
Author: Cameron Lee <calee@...>
Date: 2018-09-18T17:39:41Z
variable initialization to null in tests, rename testBasicProcess to
testProcess
----
> Refactor SamzaContainer and TaskInstance unit tests to make shared context
> changes easier
> -----------------------------------------------------------------------------------------
>
> Key: SAMZA-1874
> URL: https://issues.apache.org/jira/browse/SAMZA-1874
> Project: Samza
> Issue Type: Improvement
> Reporter: Cameron Lee
> Assignee: Cameron Lee
> Priority: Major
>
> For SAMZA-1714, there are some constructor/method signature changes. Some of
> those constructors/methods are widely used in unit tests. There is an
> opportunity to refactor the unit tests so that the signature changes are
> easier to handle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
