Repository: samza Updated Branches: refs/heads/master 76dc4cdd4 -> d88a3cd5f
SAMZA-1818: Cleaning up TestRunner Apis to incorporate LegacyTaskApplication and SamzaApplication Author: Sanil15 <[email protected]> Reviewers: Prateek Maheshwari <[email protected]>, Yi Pan <[email protected]> Closes #652 from Sanil15/SAMZA-1818 Project: http://git-wip-us.apache.org/repos/asf/samza/repo Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/d88a3cd5 Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/d88a3cd5 Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/d88a3cd5 Branch: refs/heads/master Commit: d88a3cd5ff48289daf46580d24f79fa3fcc6a4ce Parents: 76dc4cd Author: Sanil15 <[email protected]> Authored: Fri Sep 28 14:21:47 2018 -0700 Committer: Prateek Maheshwari <[email protected]> Committed: Fri Sep 28 14:21:47 2018 -0700 ---------------------------------------------------------------------- .../org/apache/samza/test/framework/TestRunner.java | 14 ++++++-------- .../framework/AsyncStreamTaskIntegrationTest.java | 2 -- .../test/framework/StreamTaskIntegrationTest.java | 2 +- 3 files changed, 7 insertions(+), 11 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/samza/blob/d88a3cd5/samza-test/src/main/java/org/apache/samza/test/framework/TestRunner.java ---------------------------------------------------------------------- diff --git a/samza-test/src/main/java/org/apache/samza/test/framework/TestRunner.java b/samza-test/src/main/java/org/apache/samza/test/framework/TestRunner.java index 6d6613c..fe8581b 100644 --- a/samza-test/src/main/java/org/apache/samza/test/framework/TestRunner.java +++ b/samza-test/src/main/java/org/apache/samza/test/framework/TestRunner.java @@ -33,7 +33,6 @@ import org.apache.commons.lang.exception.ExceptionUtils; import org.apache.samza.SamzaException; import org.apache.samza.application.LegacyTaskApplication; import org.apache.samza.application.SamzaApplication; -import org.apache.samza.application.StreamApplication; import org.apache.samza.config.Config; import org.apache.samza.config.JobConfig; import org.apache.samza.config.JobCoordinatorConfig; @@ -63,7 +62,6 @@ import org.apache.samza.test.framework.system.InMemoryOutputDescriptor; import org.apache.samza.test.framework.system.InMemorySystemDescriptor; import org.junit.Assert; - /** * TestRunner provides APIs to set up integration tests for a Samza application. * Running mode for test is Single container mode @@ -102,7 +100,7 @@ public class TestRunner { /** * Constructs a new {@link TestRunner} from following components - * @param taskClass represent a class containing Samza job logic extending either {@link StreamTask} or {@link AsyncStreamTask} + * @param taskClass containing Samza job logic extending either {@link StreamTask} or {@link AsyncStreamTask} */ private TestRunner(Class taskClass) { this(); @@ -113,9 +111,9 @@ public class TestRunner { /** * Constructs a new {@link TestRunner} from following components - * @param app samza job implementing {@link StreamApplication} + * @param app a {@link SamzaApplication} */ - private TestRunner(StreamApplication app) { + private TestRunner(SamzaApplication app) { this(); Preconditions.checkNotNull(app); this.app = app; @@ -134,11 +132,11 @@ public class TestRunner { } /** - * Creates an instance of {@link TestRunner} for High Level/Fluent Samza Api - * @param app samza job implementing {@link StreamApplication} + * Creates an instance of {@link TestRunner} for a {@link SamzaApplication} + * @param app a {@link SamzaApplication} * @return this {@link TestRunner} */ - public static TestRunner of(StreamApplication app) { + public static TestRunner of(SamzaApplication app) { Preconditions.checkNotNull(app); return new TestRunner(app); } http://git-wip-us.apache.org/repos/asf/samza/blob/d88a3cd5/samza-test/src/test/java/org/apache/samza/test/framework/AsyncStreamTaskIntegrationTest.java ---------------------------------------------------------------------- diff --git a/samza-test/src/test/java/org/apache/samza/test/framework/AsyncStreamTaskIntegrationTest.java b/samza-test/src/test/java/org/apache/samza/test/framework/AsyncStreamTaskIntegrationTest.java index 581b1c3..ef9508a 100644 --- a/samza-test/src/test/java/org/apache/samza/test/framework/AsyncStreamTaskIntegrationTest.java +++ b/samza-test/src/test/java/org/apache/samza/test/framework/AsyncStreamTaskIntegrationTest.java @@ -161,6 +161,4 @@ public class AsyncStreamTaskIntegrationTest { .addOutputStream(imod, 1) .run(Duration.ofMillis(1)); } - - } http://git-wip-us.apache.org/repos/asf/samza/blob/d88a3cd5/samza-test/src/test/java/org/apache/samza/test/framework/StreamTaskIntegrationTest.java ---------------------------------------------------------------------- diff --git a/samza-test/src/test/java/org/apache/samza/test/framework/StreamTaskIntegrationTest.java b/samza-test/src/test/java/org/apache/samza/test/framework/StreamTaskIntegrationTest.java index 0580598..bc5cba7 100644 --- a/samza-test/src/test/java/org/apache/samza/test/framework/StreamTaskIntegrationTest.java +++ b/samza-test/src/test/java/org/apache/samza/test/framework/StreamTaskIntegrationTest.java @@ -167,4 +167,4 @@ public class StreamTaskIntegrationTest { expectedOutputPartitionData.put(i, new ArrayList<Integer>(outputPartition)); } } -} +} \ No newline at end of file
