[ 
https://issues.apache.org/jira/browse/SAMZA-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704115#comment-16704115
 ] 

ASF GitHub Bot commented on SAMZA-2002:
---------------------------------------

GitHub user shenodaguirguis opened a pull request:

    https://github.com/apache/samza/pull/831

    [SAMZA-2002] SamzaSQL Diagnostics: instrument rest of operators (except 
join & aggregate) and at Query level

    Second phase of instrumenting SamzaSQL operators to add and maintain 
metrics. All operators, except join and aggregate, are instrumented to add 
Processing Time and Input Rate metrics. Whenever output rate could be different 
(e.g., filter operator) the output rate is also added. At query level, we have 
Query Latency, and input and output rates.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shenodaguirguis/samza addmetrics.3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/831.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #831
    
----
commit 8bad8066204657b1bfb2c7dedca39d869bf352e8
Author: Shenoda Guirguis <sguirguis@...>
Date:   2018-11-28T21:49:55Z

    SAMZA-2002 SamzaSQL Diagnostics: instrument rest of operators (except join) 
and at Query level

commit 3741c1cf8168e39aa2777e9fb10784a117ea2117
Author: Shenoda Guirguis <sguirguis@...>
Date:   2018-11-29T17:46:37Z

    fixing conflicts

commit 0a8218115abaab43edbc53974f87261035472db0
Author: Shenoda Guirguis <sguirguis@...>
Date:   2018-11-30T00:48:10Z

    atmoola feedback

commit 2f3dd7a5eb33971ea7a12ee64184c5bb271514ae
Author: Shenoda Guirguis <sguirguis@...>
Date:   2018-11-30T00:49:59Z

    SAMZA-2002 SamzaSQL Diagnostics: instrument rest of operators (except join) 
and at Query level

commit 8b6b49863a4092a822cf51a4a766d4121d5050d5
Author: Shenoda Guirguis <sguirguis@...>
Date:   2018-11-30T01:21:09Z

    SAMZA-2002 SamzaSQL Diagnostics: instrument rest of operators (except join) 
and at Query level

----


> Instrument Rest of Operators (except Join) and Query 
> -----------------------------------------------------
>
>                 Key: SAMZA-2002
>                 URL: https://issues.apache.org/jira/browse/SAMZA-2002
>             Project: Samza
>          Issue Type: Sub-task
>            Reporter: Shenoda Guirguis
>            Priority: Major
>
> Continue adding metrics to rest of Operators, except Join, and also add the 
> Query level metrics



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to