Repository: samza Updated Branches: refs/heads/master 2aa18b825 -> bdce47707
Fix minor issue with operator spec graph traversal Remove redundant traversal loop added by mistake during conflict merge. Author: Ahmed Abdul Hamid <[email protected]> Reviewers: Aditya Toomla <[email protected]> Closes #833 from ahmedahamid/master Project: http://git-wip-us.apache.org/repos/asf/samza/repo Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/bdce4770 Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/bdce4770 Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/bdce4770 Branch: refs/heads/master Commit: bdce47707a32f91032574f1d6d05b6e659a4aa33 Parents: 2aa18b8 Author: Ahmed Abdul Hamid <[email protected]> Authored: Fri Nov 30 10:33:35 2018 -0800 Committer: Prateek Maheshwari <[email protected]> Committed: Fri Nov 30 10:33:35 2018 -0800 ---------------------------------------------------------------------- .../org/apache/samza/execution/OperatorSpecGraphAnalyzer.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/samza/blob/bdce4770/samza-core/src/main/java/org/apache/samza/execution/OperatorSpecGraphAnalyzer.java ---------------------------------------------------------------------- diff --git a/samza-core/src/main/java/org/apache/samza/execution/OperatorSpecGraphAnalyzer.java b/samza-core/src/main/java/org/apache/samza/execution/OperatorSpecGraphAnalyzer.java index b3ecfeb..d84b418 100644 --- a/samza-core/src/main/java/org/apache/samza/execution/OperatorSpecGraphAnalyzer.java +++ b/samza-core/src/main/java/org/apache/samza/execution/OperatorSpecGraphAnalyzer.java @@ -22,6 +22,7 @@ package org.apache.samza.execution; import com.google.common.collect.HashMultimap; import com.google.common.collect.Multimap; import com.google.common.collect.Multimaps; +import java.util.Arrays; import java.util.Collection; import java.util.Collections; import java.util.HashSet; @@ -84,10 +85,7 @@ import org.apache.samza.operators.spec.StreamTableJoinOperatorSpec; */ private static void traverse(OperatorSpec startOpSpec, Consumer<OperatorSpec> visitor, Function<OperatorSpec, Iterable<OperatorSpec>> getNextOpSpecs) { - visitor.accept(startOpSpec); - for (OperatorSpec nextOpSpec : getNextOpSpecs.apply(startOpSpec)) { - traverseHelper(startOpSpec, visitor, getNextOpSpecs, new HashSet<>()); - } + traverseHelper(startOpSpec, visitor, getNextOpSpecs, new HashSet<>(Arrays.asList(startOpSpec))); } private static void traverseHelper(OperatorSpec startOpSpec, Consumer<OperatorSpec> visitor,
