This is an automated email from the ASF dual-hosted git repository.
jagadish pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/samza.git
The following commit(s) were added to refs/heads/master by this push:
new 063f883 SEP-19: Removing standbytasks.enabled config
063f883 is described below
commit 063f8833868c2ce04d79eb1723429f12622090a9
Author: Ray Matharu <[email protected]>
AuthorDate: Fri Mar 8 15:09:14 2019 -0800
SEP-19: Removing standbytasks.enabled config
Author: Ray Matharu <[email protected]>
Reviewers: Jagadish<[email protected]>
Closes #946 from rmatharu/removing-standby-config
---
samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala
b/samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala
index a84c5b8..64235cf 100644
--- a/samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala
+++ b/samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala
@@ -111,9 +111,8 @@ object JobConfig {
val JOB_DIAGNOSTICS_ENABLED = "job.diagnostics.enabled"
// Enables standby tasks
- val STANDBY_TASKS_ENABLED = "job.standbytasks.enabled"
val STANDBY_TASKS_REPLICATION_FACTOR = "job.standbytasks.replication.factor"
- val DEFAULT_STANDBY_TASKS_REPLICATION_FACTOR = 2
+ val DEFAULT_STANDBY_TASKS_REPLICATION_FACTOR = 1
// Specify DiagnosticAppender class
val DIAGNOSTICS_APPENDER_CLASS = "job.diagnostics.appender.class"
@@ -274,7 +273,7 @@ class JobConfig(config: Config) extends
ScalaMapConfig(config) with Logging {
get(JobConfig.SYSTEM_STREAM_PARTITION_MAPPER_FACTORY,
classOf[HashSystemStreamPartitionMapperFactory].getName)
}
- def getStandbyTasksEnabled = getBoolean(JobConfig.STANDBY_TASKS_ENABLED,
false)
+ def getStandbyTasksEnabled = getStandbyTaskReplicationFactor > 1
def getStandbyTaskReplicationFactor =
getInt(JobConfig.STANDBY_TASKS_REPLICATION_FACTOR,
JobConfig.DEFAULT_STANDBY_TASKS_REPLICATION_FACTOR)
}