dnishimura commented on a change in pull request #987: SAMZA-2158: Remove the
redunant coordinator stream reads in the ApplicationMaster startup sequence.
URL: https://github.com/apache/samza/pull/987#discussion_r272645814
##########
File path:
samza-core/src/main/java/org/apache/samza/startpoint/StartpointManager.java
##########
@@ -78,6 +77,14 @@ public StartpointManager(MetadataStoreFactory
metadataStoreFactory, Config confi
LOG.info("StartpointManager created with metadata store: {}",
metadataStore.getClass().getCanonicalName());
}
+ /**
+ * Constructs a {@link StartpointManager} instance.
Review comment:
nit: Update the two constructor javadocs to inform the intent. i.e. this
constructor is used to share the metadata store connection between various
components and the constructor above is intended for external use (or something
along those lines).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
