prateekm commented on a change in pull request #987: SAMZA-2158: Remove the
redunant coordinator stream reads in the ApplicationMaster startup sequence.
URL: https://github.com/apache/samza/pull/987#discussion_r273175885
##########
File path:
samza-core/src/main/java/org/apache/samza/container/grouper/task/TaskPartitionAssignmentManager.java
##########
@@ -50,20 +50,13 @@
private final MetadataStore metadataStore;
/**
- * <ul>
- * <li>
- * <p>
- * Builds the TaskPartitionAssignmentManager based upon the provided
{@link MetadataStore} that is instantiated.
- * Setting up a metadata store instance is expensive which requires
opening multiple connections
- * and reading a lot of information. Fully instantiated metadata store
is taken as a constructor argument
- * to reuse it across different utility classes.
- * </p>
- * </li>
- *
- * <li>
- * Uses the {@link CoordinatorStreamValueSerde} to serialize messages
before reading/writing into metadata store.
- * </li>
- * </ul>
+ * <p>
Review comment:
Do you need a <p> for a single paragraph? The other list item isn't relevant?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
