rmatharu commented on a change in pull request #989: Added an AM metric for
configured container cpu and memory.
URL: https://github.com/apache/samza/pull/989#discussion_r273710424
##########
File path:
samza-core/src/main/scala/org/apache/samza/metrics/ContainerProcessManagerMetrics.scala
##########
@@ -73,6 +75,9 @@ class ContainerProcessManagerMetrics(
val mFailoversToAnyHost = newGauge("failovers-to-any-host", () =>
state.failoversToAnyHost.get())
val mFailoversToStandby = newGauge("failovers-to-standby", () =>
state.failoversToStandby.get())
+ val mContainerMemoryMb = newGauge("container-memory-mb", () =>
clusterManagerConfig.getContainerMemoryMb)
+ val mContainerCpuCores = newGauge("container-cpu-cores", () =>
clusterManagerConfig.getNumCores)
+
Review comment:
Making a note: We may want to in future consolidate this information, so
that its only emitted from either the Containers themselves (in case of
heterogenous containers), or from the AM (including other container details
such as XmX size).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
