shanthoosh commented on a change in pull request #990: SAMZA-2161: Move
ChangelogPartitionManager and CoordinatorStream ConfigReader to MetadataStore.
URL: https://github.com/apache/samza/pull/990#discussion_r274058827
##########
File path:
samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala
##########
@@ -126,8 +127,9 @@ object CheckpointTool {
}
def apply(config: Config, offsets: TaskNameToCheckpointMap): CheckpointTool
= {
- val coordinatorStreamManager = new CoordinatorStreamManager(config, new
MetricsRegistryMap())
- new CheckpointTool(offsets, coordinatorStreamManager)
+ val metadataStore: CoordinatorStreamStore = new
CoordinatorStreamStore(config, new MetricsRegistryMap())
+ metadataStore.init()
Review comment:
Helps to build unit tests easily by injecting a mock MetadataStore as a
dependency into the checkpointTool#run method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
