prateekm commented on a change in pull request #993: SAMZA-2164: Close the
consumer after reading checkpoints
URL: https://github.com/apache/samza/pull/993#discussion_r275085473
##########
File path:
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala
##########
@@ -128,11 +128,11 @@ class KafkaCheckpointManager(checkpointSpec:
KafkaStreamSpec,
info(s"Reading checkpoint for taskName $taskName")
if (taskNamesToCheckpoints == null) {
- debug("Reading checkpoints for the first time")
+ info("Reading checkpoints for the first time")
taskNamesToCheckpoints = readCheckpoints()
- } else {
- debug("Updating existing checkpoint mappings")
- taskNamesToCheckpoints ++= readCheckpoints()
+ // Stop the system consumer since we only need to read checkpoints once
Review comment:
Don't need the else anymore?
If not, does it make sense to move the register and start here as well?
Maybe even make it local to the method instead of a field? Is it used for
anything else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
