mynameborat commented on a change in pull request #984: Samza 2116: Making
sendTo(table), sendTo(stream) non-terminal
URL: https://github.com/apache/samza/pull/984#discussion_r275505490
##########
File path:
samza-api/src/main/java/org/apache/samza/operators/MessageStream.java
##########
@@ -127,8 +128,9 @@
* When sending messages to any other {@code OutputStream<M>}, messages are
partitioned using a null partition key.
*
* @param outputStream the output stream to send messages to
+ * @return the input {@link MessageStream}
*/
- void sendTo(OutputStream<M> outputStream);
+ MessageStream<M> sendTo(OutputStream<M> outputStream);
Review comment:
Seems a little complicated. Not sure what written here refers to `sending to
the underlying system or flushing to it`.
Can we simplify the note along the lines of "no happens before guarantee
between the message that is propagated to downstream DAG and the send to the
underlying output system".
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
