prateekm commented on a change in pull request #995: SAMZA-2165: Account for
coordinator restarts in calls to status
URL: https://github.com/apache/samza/pull/995#discussion_r275583600
##########
File path:
samza-yarn/src/main/scala/org/apache/samza/job/yarn/ClientHelper.scala
##########
@@ -350,6 +350,11 @@ class ClientHelper(conf: Configuration) extends Logging {
} else {
false
}
+ } catch {
+ case e: IOException => {
Review comment:
Minor: Would prefer to not guess the exception cause in the exception
message. Maybe instead add a comment explaining why returning false here is
better.
What was the previous behavior? Does the caller catch the exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
