rmatharu commented on a change in pull request #995: SAMZA-2165: Account for 
coordinator restarts in calls to status
URL: https://github.com/apache/samza/pull/995#discussion_r275584059
 
 

 ##########
 File path: 
samza-yarn/src/main/scala/org/apache/samza/job/yarn/ClientHelper.scala
 ##########
 @@ -350,6 +350,11 @@ class ClientHelper(conf: Configuration) extends Logging {
       } else {
         false
       }
+    } catch {
+      case e: IOException => {
+        warn("Exception when querying AM metrics. Likely because YARN was 
re-starting a new AM attempt", e)
 
 Review comment:
   an IOException in querying AM could be because of a few other reasons as 
well, right?
   Also, maybe we want to catch any exception?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to