cameronlee314 opened a new pull request #996: SAMZA-2166: [Scala cleanup] Convert StorageConfig.scala to Java URL: https://github.com/apache/samza/pull/996 Note: This also seems to fix a bug in `BaseKeyValueStorageEngineFactory` which involved reading the access log sample ratio config. Previously, the config being passed in to `BaseKeyValueStorageEngineFactory` was stripped of the `stores.<store name>.` prefix, but it was implicitly converted into a `StorageConfig`, so when `getAccessLogSamplingRatio` was called, it seems like it would never actually find the full `stores.<store name>.accesslog.sampling.ratio`. This meant it always fell back to the default value.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
