weisong44 commented on a change in pull request #986: SAMZA-2156: Couchbase support for Samza Table API URL: https://github.com/apache/samza/pull/986#discussion_r275784811
########## File path: samza-kv-remote/src/main/java/org/apache/samza/table/remote/couchbase/CouchbaseEnvironmentConfigs.java ########## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + + +package org.apache.samza.table.remote.couchbase; + +import java.io.Serializable; + + +public class CouchbaseEnvironmentConfigs implements Serializable { + public CouchbaseEnvironmentConfigs() { + } + + protected Boolean sslEnabled; + protected Boolean certAuthEnabled; + protected String sslKeystoreFile; + protected String sslKeystorePassword; + protected String sslTruststoreFile; + protected String sslTruststorePassword; + protected Integer bootstrapCarrierDirectPort; + protected Integer bootstrapCarrierSslPort; + protected Integer bootstrapHttpDirectPort; + protected Integer bootstrapHttpSslPort; + protected String username; + protected String password; + + public Boolean getSslEnabled() { Review comment: 1) this seems to be an internal helper class, can we not keep it public? 2) do we really need the getters and setters or can we just make the members public? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
