prateekm commented on a change in pull request #1003: Removing
job.diagnostics.appender.class config, and populating it based on if log4j or
log4j2 is class-loaded
URL: https://github.com/apache/samza/pull/1003#discussion_r276862921
##########
File path: samza-core/src/main/scala/org/apache/samza/util/Util.scala
##########
@@ -62,6 +62,21 @@ object Util extends Logging {
}
}
+ /**
+ * Instantiate an object from given className, and given constructor
parameters.
+ */
+ def getObj(className: String, constructorParams: (Class[_], Object)*) : Any
= {
Review comment:
Should not return Any, can take [T] as a generic param and require passing
the type (see other variant)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
