TisonKun commented on issue #999: Add generic type info in ApplicationRunnerMain URL: https://github.com/apache/samza/pull/999#issuecomment-485053750 Thanks for your reply @vjagadish1989 ! FYI travis fails on ``` testRepartitionedSessionWindowCounter FAILED org.junit.ComparisonFailure: expected:<[3]> but was:<[4]> at org.junit.Assert.assertEquals(Assert.java:115) at org.junit.Assert.assertEquals(Assert.java:144) at org.apache.samza.test.operator.TestRepartitionWindowApp.testRepartitionedSessionWindowCounter(TestRepartitionWindowApp.java:80) shouldStopNewProcessorsJoiningGroupWhenNumContainersIsGreaterThanNumTasks FAILED java.lang.AssertionError: expected:<JobModel [config={}, containers={0000000000=ContainerModel [id=0000000000, tasks={SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 4]=TaskModel [taskName=SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 4], systemStreamPartitions=[SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 4]], changeLogPartition=Partition [partition=4], taskMode=Active], SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 0]=TaskModel [taskName=SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 0], systemStreamPartitions=[SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 0]], changeLogPartition=Partition [partition=0], taskMode=Active], SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 1]=TaskModel [taskName=SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 1], systemStreamPartitions=[SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 1]], changeLogPartition=Partition [partition=1], taskMode=Active], SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 2]=TaskModel [taskName=SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 2], systemStreamPartitions=[SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 2]], changeLogPartition=Partition [partition=2], taskMode=Active], SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 3]=TaskModel [taskName=SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 3], systemStreamPartitions=[SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 3]], changeLogPartition=Partition [partition=3], taskMode=Active]}]}]> but was:<JobModel [config={}, containers={0000000000=ContainerModel [id=0000000000, tasks={SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 4]=TaskModel [taskName=SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 4], systemStreamPartitions=[SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 4]], changeLogPartition=Partition [partition=4], taskMode=Active], SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 0]=TaskModel [taskName=SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 0], systemStreamPartitions=[SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 0]], changeLogPartition=Partition [partition=0], taskMode=Active], SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 3]=TaskModel [taskName=SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 3], systemStreamPartitions=[SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 3]], changeLogPartition=Partition [partition=3], taskMode=Active]}], 0000000001=ContainerModel [id=0000000001, tasks={SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 1]=TaskModel [taskName=SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 1], systemStreamPartitions=[SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 1]], changeLogPartition=Partition [partition=1], taskMode=Active], SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 2]=TaskModel [taskName=SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 2], systemStreamPartitions=[SystemStreamPartition [TestSystemName, test-input-single-partition-topic-86452e7f-2d17-488b-b34c-8720b828d466, 2]], changeLogPartition=Partition [partition=2], taskMode=Active]}]}]> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:144) at org.apache.samza.test.processor.TestZkLocalApplicationRunner.shouldStopNewProcessorsJoiningGroupWhenNumContainersIsGreaterThanNumTasks(TestZkLocalApplicationRunner.java:289) 252 tests completed, 2 failed, 3 skipped :samza-test_2.11:test FAILED ``` https://api.travis-ci.org/v3/job/521496987/log.txt which I think is irrelevant to this pr.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
