Zhangyx39 commented on a change in pull request #982: SAMZA-2153: Implement to
Config for TableRetryPolicy
URL: https://github.com/apache/samza/pull/982#discussion_r277507257
##########
File path:
samza-api/src/main/java/org/apache/samza/table/descriptors/RemoteTableDescriptor.java
##########
@@ -135,6 +139,8 @@ public RemoteTableDescriptor(String tableId) {
Preconditions.checkNotNull(readFn, "null read function");
Preconditions.checkNotNull(retryPolicy, "null retry policy");
this.readRetryPolicy = retryPolicy;
+ this.readRetryPolicy.setTableId(String.format("%s.%s", tableId,
Review comment:
Another way could be: when TableRetryPolicy implements toConfig method, it
doesn't put the tableId as part of the key. We then append the tableId to the
key here in RemoteTableDescriptor`.
This way, a TableRetryFunction can be shared by any number of tables,
because there is no tableId associated to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
