dnishimura commented on a change in pull request #1016: SAMZA-2179: Move the
StartpointVisitor abstraction to SystemAdmin interface.
URL: https://github.com/apache/samza/pull/1016#discussion_r279825309
##########
File path:
samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsumer.java
##########
@@ -167,12 +142,11 @@ public void start() {
private void startSubscription() {
//subscribe to all the registered TopicPartitions
- Set<TopicPartition> registeredTopicPartitions = new
HashSet<>(topicPartitionToStartpointMap.keySet());
- LOG.info("{}: Consumer subscribes to {}", this, registeredTopicPartitions);
+ LOG.info("{}: Consumer subscribes to {}", this,
topicPartitionsToSSP.keySet());
try {
synchronized (kafkaConsumer) {
// we are using assign (and not subscribe), so we need to specify both
topic and partition
- kafkaConsumer.assign(registeredTopicPartitions);
+ kafkaConsumer.assign(topicPartitionsToSSP.keySet());
Review comment:
Do you think it'll be beneficial to use the `ThreadSafeKafkaConsumer`
wrapper class? Maybe as part of the follow up PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
