lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531:
Support run.id in standalone for batch processing.
URL: https://github.com/apache/samza/pull/938#discussion_r282737569
##########
File path:
samza-core/src/main/java/org/apache/samza/coordinator/DistributedLock.java
##########
@@ -19,24 +19,22 @@
package org.apache.samza.coordinator;
-import java.util.concurrent.TimeUnit;
+import java.time.Duration;
import java.util.concurrent.TimeoutException;
-public interface DistributedLockWithState {
+public interface DistributedLock {
/**
- * Try to acquire the lock, but first check if the state flag is set. If it
is set, return false.
- * If the flag is not set, and lock is acquired - return true.
+ * Try to acquire the lock
* @param timeout Duration of lock acquiring timeout.
- * @param unit Time Unit of the timeout defined above.
- * @return true if lock is acquired successfully, false if state is already
set.
+ * @return true if lock is acquired successfully
Review comment:
removed Timeout Exception and returning `false` instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
