cameronlee314 commented on a change in pull request #1027: SAMZA-2046: Startpoint fan out implementation URL: https://github.com/apache/samza/pull/1027#discussion_r284414813
########## File path: samza-api/src/main/java/org/apache/samza/startpoint/Startpoint.java ########## @@ -22,11 +22,13 @@ import com.google.common.base.Objects; import java.time.Instant; import org.apache.samza.annotation.InterfaceStability; +import org.codehaus.jackson.annotate.JsonTypeInfo; /** * Startpoint represents a position in a stream partition. */ @InterfaceStability.Evolving +@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include = JsonTypeInfo.As.PROPERTY, property = "@type") Review comment: Is there a way to add this annotation info in `StartpointObjectMapper`? That object mapper already does some JSON configuration, and it would be nice to decouple all of the JSON serialization code from the actual `Startpoint`, since it is part of the API. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
