dnishimura commented on a change in pull request #1027: SAMZA-2046: Startpoint fan out implementation URL: https://github.com/apache/samza/pull/1027#discussion_r284751424
########## File path: samza-api/src/main/java/org/apache/samza/startpoint/Startpoint.java ########## @@ -22,11 +22,13 @@ import com.google.common.base.Objects; import java.time.Instant; import org.apache.samza.annotation.InterfaceStability; +import org.codehaus.jackson.annotate.JsonTypeInfo; /** * Startpoint represents a position in a stream partition. */ @InterfaceStability.Evolving +@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include = JsonTypeInfo.As.PROPERTY, property = "@type") Review comment: [There seems to be a way](https://stackoverflow.com/a/41982776), but it's not working when I try it out for some reason. It may be due to the fact that we're on a really old version of `jackson`. The version we're using is so old that the recent versions of `jackson` have different package names. I'll leave the annotation for now and investigate moving us to a newer version of jackson in a separate PR/ticket. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
