mynameborat commented on a change in pull request #991: [SAMZA-2162] - Update
Table APIs to be consistent with High level Async API
URL: https://github.com/apache/samza/pull/991#discussion_r286660595
##########
File path:
samza-core/src/main/java/org/apache/samza/operators/impl/SendToTableOperatorImpl.java
##########
@@ -56,9 +55,9 @@ protected void handleInit(Context context) {
@Override
protected CompletionStage<Collection<Void>> handleMessageAsync(KV<K, V>
message, MessageCollector collector,
TaskCoordinator coordinator) {
- table.put(message.getKey(), message.getValue());
// there should be no further chained operators since this is a terminal
operator.
- return CompletableFuture.completedFuture(Collections.emptyList());
+ return table.putAsync(message.getKey(), message.getValue())
Review comment:
Synced up offline about this. This doesn't change semantics in any ways than
what it is today.
The scenario outlined is only possible when task.max.concurrency is set to >
1.
In case of task.max.concurrency, we expect the application to coordinate its
shared states since there is no happens-before guarantee between messages
delivered to the DAG.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
