celiakung commented on a change in pull request #1063: SAMZA-2234: Passing
context to Samza SQL UDFs
URL: https://github.com/apache/samza/pull/1063#discussion_r290384882
##########
File path: samza-sql/src/main/java/org/apache/samza/sql/data/Expression.java
##########
@@ -29,10 +30,10 @@
public interface Expression {
/**
* This method is used to implement the expressions that takes in columns as
input and returns multiple values.
- * @param context the context
+ * @param context SamzaSqlExecution context
Review comment:
nit: the variable name should be 'sqlContext'
and need to add another param on the next line for regular 'context'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
