rmatharu commented on a change in pull request #1066: SAMZA-2235: Move the
merging of side inputs with task inputs from the ExecutionPlanner to the
JobModelManager
URL: https://github.com/apache/samza/pull/1066#discussion_r290520075
##########
File path:
samza-core/src/main/scala/org/apache/samza/coordinator/JobModelManager.scala
##########
@@ -267,8 +266,6 @@ object JobModelManager extends Logging {
* @return the input {@see SystemStreamPartition} of the samza job.
*/
private def getInputStreamPartitions(config: Config, streamMetadataCache:
StreamMetadataCache): Set[SystemStreamPartition] = {
Review comment:
Could we add the following to the javadoc:
Computes the input system stream partitions of a samza job using the
provided config.
Adds side-inputs to inputSystemStreams, and expands all input topic regexes
and populates them.
thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
