Sanil15 commented on a change in pull request #1066: SAMZA-2235: Move the
merging of side inputs with task inputs from the ExecutionPlanner to the
JobModelManager
URL: https://github.com/apache/samza/pull/1066#discussion_r290549878
##########
File path:
samza-core/src/main/scala/org/apache/samza/coordinator/JobModelManager.scala
##########
@@ -279,9 +276,16 @@ object JobModelManager extends Logging {
case _ => config
}
}
+ val rewrittenConfigs = invokeRegexTopicRewriter(rewrittenConfigs)
+
+ val storageConfig = new StorageConfig(rewrittenConfigs)
+ val sideInputs = storageConfig.getStoreNames.asScala
+ .flatMap(storeName => storageConfig.getSideInputs(storeName).asScala)
+ .map(sideInput =>
StreamUtil.getSystemStreamFromNameOrId(rewrittenConfigs, sideInput))
+ .toList
// Expand regex input, if a regex-rewriter is defined in config
Review comment:
minor: this comment needs to be placed above with val rewrittenConfigs =
invokeRegexTopicRewriter(rewrittenConfigs)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
