rmatharu commented on a change in pull request #1086: SAMZA-2256: Hotstandby
fix for exception while reading side inputs
URL: https://github.com/apache/samza/pull/1086#discussion_r295105359
##########
File path:
samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java
##########
@@ -705,43 +714,42 @@ public void run() {
this.sideInputSystemConsumers.start();
// create a thread for sideInput reads
- Thread readSideInputs = new Thread(() -> {
- while (!shutDownSideInputRead) {
- IncomingMessageEnvelope envelope =
sideInputSystemConsumers.choose(true);
- if (envelope != null) {
-
- if (!envelope.isEndOfStream())
-
sideInputStorageManagers.get(envelope.getSystemStreamPartition()).process(envelope);
+ Thread readSideInputsThread = new Thread(() -> {
+ try {
+ while (!shutDownSideInputRead) {
+ IncomingMessageEnvelope envelope =
sideInputSystemConsumers.choose(true);
+ if (envelope != null) {
- checkSideInputCaughtUp(envelope.getSystemStreamPartition(),
envelope.getOffset(),
- SystemStreamMetadata.OffsetType.NEWEST,
envelope.isEndOfStream());
+ if (!envelope.isEndOfStream())
+
sideInputStorageManagers.get(envelope.getSystemStreamPartition()).process(envelope);
- } else {
- LOG.trace("No incoming message was available");
+ checkSideInputCaughtUp(envelope.getSystemStreamPartition(),
envelope.getOffset(),
Review comment:
Sure, this method is mostly akin to TaskInstance.checkCaughtUp.
I will try to simplify this in SAMZA-2257
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
