vjagadish1989 commented on a change in pull request #1086: SAMZA-2256:
Hotstandby fix for exception while reading side inputs
URL: https://github.com/apache/samza/pull/1086#discussion_r295427905
##########
File path:
samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java
##########
@@ -828,7 +842,8 @@ public void shutdown() {
// stop all sideinput consumers and stores
if (sideInputsPresent()) {
// stop reading sideInputs
- this.shutDownSideInputRead = true;
+ this.shouldShutdown = true;
Review comment:
consider moving this out of the sideInputsPresent path - since it's now a
general purpose shutdown mechanism for this class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
