shanthoosh commented on a change in pull request #1079: SAMZA-2250: Support
large job models in standalone.
URL: https://github.com/apache/samza/pull/1079#discussion_r296054447
##########
File path: samza-core/src/main/java/org/apache/samza/zk/ZkMetadataStore.java
##########
@@ -64,25 +69,47 @@ public void init() {
*/
@Override
public byte[] get(String key) {
- return zkClient.readData(getZkPathForKey(key), true);
+ byte[] aggregatedZNodeValues = new byte[0];
+ for (int segmentIndex = 0;; ++segmentIndex) {
+ String zkPath = getZkPath(key, segmentIndex);
+ byte[] zNodeValue = zkClient.readData(zkPath, true);
+ if (zNodeValue == null) {
+ break;
+ }
+ aggregatedZNodeValues = Bytes.concat(aggregatedZNodeValues, zNodeValue);
+ }
+ if (aggregatedZNodeValues.length > 0) {
+ byte[] value = ArrayUtils.subarray(aggregatedZNodeValues, 0,
aggregatedZNodeValues.length - CHECKSUM_SIZE_IN_BYTES);
+ byte[] checkSum = ArrayUtils.subarray(aggregatedZNodeValues,
aggregatedZNodeValues.length - CHECKSUM_SIZE_IN_BYTES,
aggregatedZNodeValues.length);
+ byte[] expectedCheckSum = getCRCChecksum(value);
+ if (!Arrays.equals(checkSum, expectedCheckSum)) {
+ throw new IllegalStateException("Expected checksum of value did not
match the actual checksum");
Review comment:
I think the upper layers viz the SamzaContainer/StreamProcessor already logs
exception before shutdown. Logging here again will be redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
