dnishimura commented on a change in pull request #1079: SAMZA-2250: Support large job models in standalone. URL: https://github.com/apache/samza/pull/1079#discussion_r296875226
########## File path: samza-core/src/test/java/org/apache/samza/zk/TestZkJobCoordinator.java ########## @@ -62,12 +68,15 @@ import static org.mockito.Mockito.verifyZeroInteractions; import static org.mockito.Mockito.when; +@RunWith(PowerMockRunner.class) Review comment: Question for @prateekm and @cameronlee314 (unrelated to this specific PR, but related to this comment) In prior code reviews, @cameronlee314 mentioned that private methods should be static whenever possible so we can test/validate such methods easier. However, the only way to verify static methods are called in a test is to use PowerMock. What should be the proper convention for testing these type of static methods if PowerMock is discouraged? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
