Urtzi Urdapilleta Roy created SAMZA-2261:
--------------------------------------------
Summary: Shell scripts not using log4j-console.xml by default
Key: SAMZA-2261
URL: https://issues.apache.org/jira/browse/SAMZA-2261
Project: Samza
Issue Type: Bug
Affects Versions: 1.0, 1.1, 1.2
Reporter: Urtzi Urdapilleta Roy
It seems that the changes in this ticket to support log4j2
(https://issues.apache.org/jira/browse/SAMZA-1783) are not working as expected
in the samza-shell bash scripts:
The extra checks added to check the presence of log4j2 or log4j jars are using
the variable *base_dir*, but it's not set in most of the scripts prior invoking
_run-class.sh_. This makes the checks fail as the jar files can't be found:
[https://github.com/apache/samza/blob/1.0.0/samza-shell/src/main/bash/run-job.sh#L19]
The _run-app.sh_ script sets the *base_dir* variable:
[https://github.com/apache/samza/blob/1.0.0/samza-shell/src/main/bash/run-app.sh#L19]
The other scripts could be updated to include the same lines to set *base_dir*
before attempting to modify the log4j configuration options. I'm glad to open a
PR with the changes if you agree with the fix.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
