mynameborat commented on issue #1066: SAMZA-2235: Move the merging of side inputs with task inputs from the ExecutionPlanner to the JobModelManager URL: https://github.com/apache/samza/pull/1066#issuecomment-505974549 > @bharathkk > Since the CSM creates a separate SystemConsumers with a default chooser just for side-inputs, wouldnt that be sufficient to respect priorities across side-inputs? > `MessageChooser chooser = DefaultChooser.apply(inputStreamMetadata, new RoundRobinChooserFactory(), config, sideInputSystemConsumersMetrics.registry(), systemAdmins);` > > ``` > sideInputSystemConsumers = > new SystemConsumers(chooser, ScalaJavaUtil.toScalaMap(this.sideInputConsumers), systemAdmins, serdeManager, > sideInputSystemConsumersMetrics, SystemConsumers.DEFAULT_NO_NEW_MESSAGES_TIMEOUT(), SystemConsumers.DEFAULT_DROP_SERIALIZATION_ERROR(), > TaskConfig.DEFAULT_POLL_INTERVAL_MS, ScalaJavaUtil.toScalaFunction(() -> System.nanoTime()));` > ``` SystemChooserConfig relies on task.inputs to fetch priority/bootstrap related configs.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
